Skip to content

fix: stacktrace parsing issue - #672

Merged
kodiakhq[bot] merged 3 commits into
v2from
warren/fix-stacktrace-parsing-issue
Mar 12, 2025
Merged

kodiakhq[bot] merged 3 commits into
v2from
warren/fix-stacktrace-parsing-issue

Conversation

@wrn14897

@wrn14897 wrn14897 commented Mar 12, 2025 •

Copy link
Copy Markdown
Contributor

Ref: HDX-1475

Screenshot 2025-03-12 at 2 51 42 PM

@changeset-bot

changeset-bot Bot commented Mar 12, 2025 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: be7e68c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dhable
dhable previously approved these changes Mar 12, 2025
@kodiakhq
kodiakhq Bot merged commit 6e83154 into v2 Mar 12, 2025
@kodiakhq
kodiakhq Bot deleted the warren/fix-stacktrace-parsing-issue branch March 12, 2025 22:19
wrn14897 added a commit that referenced this pull request Sep 19, 2025
I believe the reason Anthropic was hitting the memory error is that the `metadataMaxRowsToRead` setting was applied only to a specific query (and did not include the getKeyValues method). Now, since ClickHouse settings are cached and shared across all metadata instances, every method within the Metadata class should respect these settings.

This PR also adds another CTE filtering on top of queries that touch array aggregation functions like `groupUniqArray` and `groupUniqArrayArray`

I will port this fix to OSS later

Ref: HDX-2321
knudtty pushed a commit that referenced this pull request Apr 16, 2026
Ref: HDX-1475

<img width="741" alt="Screenshot 2025-03-12 at 2 51 42 PM" src="https://github.com/user-attachments/assets/f14bf2e8-5c9a-48bd-9963-3cbaab6e5add" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants